Fix native catalog credential vending skipping allowedLocations re-validation#4860
Merged
dimas-b merged 5 commits intoJun 26, 2026
Conversation
…lidation - Always validate table locations before vending credentials for native catalogs. - Added regression test for post-creation allowedLocations shrink.
vigneshio
force-pushed
the
fix/native-credential-vending-allowed-locations-revalidation
branch
from
df46562 to
3f3eeae
Compare
dimas-b
previously approved these changes
Jun 24, 2026
dimas-b
left a comment
dimas-b
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 Thanks, @vigneshio !
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
@vigneshio : |
Contributor
Author
Resolved @dimas-b 👍 |
dimas-b
approved these changes
Jun 25, 2026
Contributor
|
@nandorKollar: WDYT? |
github-project-automation
Bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native catalog credential vending (the optimized
loadCredentialspath and delegation inloadTable) was trusting locations stored in the table entity without re-validating them against the current catalogallowedLocations.Why this is needed
After an admin tightened a catalog's allowed locations, clients could still obtain fresh STS credentials for paths that were no longer allowed. This was a defense-in-depth gap that only affected the native (non-federated) path.
Changes
isFederatedguard).loadCredentialspath.loadCredentialsis rejected..Checklist
CHANGELOG.mdunder[Unreleased] > Fixes